Data extensions editor: Implement "Hide modeled APIs" checkbox and make it the default#2651
Merged
shati-patel merged 1 commit intomainfrom Jul 27, 2023
Merged
Conversation
robertbrignull
approved these changes
Jul 27, 2023
Contributor
robertbrignull
left a comment
robertbrignull
left a comment
There was a problem hiding this comment.
LGTM, but I did help pair on it. Feel free to get another opinion if you want one.
One minor comment on naming, which you could ignore or go with a different name if you like.
| }); | ||
| }, [viewState?.mode]); | ||
|
|
||
| const onHideModeledApis = useCallback(() => { |
Contributor
There was a problem hiding this comment.
To be picky (sorry I didn't mention this while pairing) and to fit in with conventions, I believe we should call this handleHideModeledApisChanged or something like that. Calling the function itself handleX is apparently the standard convention, especially when created using useCallback.
Contributor
Author
There was a problem hiding this comment.
Thanks! [As discussed offline, I'll leave the name as-is for now since the rest of this file also doesn't follow the handleXXX convention 😅 ]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the "Hide modeled APIs" checkbox actually hide modeled APIs from the view! ✅ (With help from @robertbrignull 🙏🏽)
See internal issue for more details 🔍
Checklist
N/A: Internal only 🐄
ready-for-doc-reviewlabel there.